Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtensionContext.logUri #10033

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 0 comments · Fixed by #10650
Closed
Tracked by #9863

Add ExtensionContext.logUri #10033

tsmaeder opened this issue Sep 1, 2021 · 0 comments · Fixed by #10650
Labels
vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021

Feature Description:

We already have logPath, but we have to do the same as for the other fields like storagePath|Uri. Should be trivial. See https://code.visualstudio.com/api/references/vscode-api#ExtensionContext

@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Sep 1, 2021
JonasHelming pushed a commit that referenced this issue Jan 26, 2022
* Support 'logUri' and 'extension' (partially) to PluginContext

- Ensure 'logUri' and 'extension' property are present in context
- 'extension' currently has always theia.Plugin type, even in vscode

Fixes #10033

* Move VSCode extension mapping directly into Plugin creation

* Fix conversion with correct fields

* Incorporate feedback about naming and exports
mcgordonite pushed a commit to ARMmbed/theia that referenced this issue May 13, 2022
…e-theia#10650)

* Support 'logUri' and 'extension' (partially) to PluginContext

- Ensure 'logUri' and 'extension' property are present in context
- 'extension' currently has always theia.Plugin type, even in vscode

Fixes eclipse-theia#10033

* Move VSCode extension mapping directly into Plugin creation

* Fix conversion with correct fields

* Incorporate feedback about naming and exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
1 participant