Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canReply to CommentThread #10002

Closed
Tracked by #9863
tsmaeder opened this issue Aug 31, 2021 · 1 comment · Fixed by #11062
Closed
Tracked by #9863

Add canReply to CommentThread #10002

tsmaeder opened this issue Aug 31, 2021 · 1 comment · Fixed by #11062
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

Add the canReply field to CommentThriead. In addition to adding the field, we should not show the "reply" area in comment-thread-widget.tsx.

@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Aug 31, 2021
@vince-fugnitto vince-fugnitto changed the title Add canReply to `CommentThread Add canReply to CommentThread Aug 31, 2021
@JonasHelming JonasHelming self-assigned this Mar 25, 2022
@planger
Copy link
Contributor

planger commented Mar 25, 2022

@CamilleLetavernier started looking into this issue.

CamilleLetavernier added a commit to eclipsesource/theia that referenced this issue Apr 25, 2022
- Add canReply to the CommentThread API
- Show or Hide the Comment Reply widget based on the
CommentThread.canReply value

fixes eclipse-theia#10002

Contributed on behalf of STMicroelectronics

Signed-off-by: Camille Letavernier <[email protected]>
JonasHelming pushed a commit that referenced this issue Apr 28, 2022
- Add canReply to the CommentThread API
- Show or Hide the Comment Reply widget based on the
CommentThread.canReply value

fixes #10002

Contributed on behalf of STMicroelectronics

Signed-off-by: Camille Letavernier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants