From efd82638ca1aaaf42bb3c6b3c81970b14c45f14e Mon Sep 17 00:00:00 2001 From: Scott Axcell Date: Fri, 13 Aug 2021 12:21:39 -0600 Subject: [PATCH] Bind handleExpansionToggleDblClickEvent in TreeWidget (#9877) Ensure `handleExpansionToggleDblClickEvent` correctly bound in TreeWidget Co-authored-by: Scott Axcell --- CHANGELOG.md | 1 + packages/core/src/browser/tree/tree-widget.tsx | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 41091571efbf8..b37bf69c3cb78 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ - [core] registering toolbar items for commands that explicitly target a `ViewContainer` rather than a child widget may not behave as expected. Such registrations should be made in the `ViewContainer` by overriding the `updateToolbarItems` method and using the `registerToolbarItem` utility. See the modifications to the `scm` and `vsx-registry` packages in the PR for examples. [#9798](https://github.com/eclipse-theia/theia/pull/9798) - [vsx-registry] `VSXExtensionsContribution` no longer implements `TabBarToolbarContribution` and is not bound as such. Extensions of the class that expect such behavior should reimplement it with caution. See caveats in PR. [#9798](https://github.com/eclipse-theia/theia/pull/9798) +- [core] `handleExpansionToggleDblClickEvent` in `TreeWidget` can no longer be overridden. Instead, `doHandleExpansionToggleDblClickEvent` can be overridden. [#9877](https://github.com/eclipse-theia/theia/pull/9877) ## v1.16.0 - 7/29/2021 diff --git a/packages/core/src/browser/tree/tree-widget.tsx b/packages/core/src/browser/tree/tree-widget.tsx index 4bdcec10bb1ed..75a8ba539e3eb 100644 --- a/packages/core/src/browser/tree/tree-widget.tsx +++ b/packages/core/src/browser/tree/tree-widget.tsx @@ -1208,9 +1208,13 @@ export class TreeWidget extends ReactWidget implements StatefulWidget { /** * Handle the double-click mouse event on the expansion toggle. + */ + protected readonly handleExpansionToggleDblClickEvent = (event: React.MouseEvent) => this.doHandleExpansionToggleDblClickEvent(event); + /** + * Actually handle the double-click mouse event on the expansion toggle. * @param event the double-click mouse event. */ - protected handleExpansionToggleDblClickEvent(event: React.MouseEvent): void { + protected doHandleExpansionToggleDblClickEvent(event: React.MouseEvent): void { if (this.props.expandOnlyOnExpansionToggleClick) { // Ignore the double-click event. event.stopPropagation();