You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal comment by @HeikoKlare
I see some options for improving the design of this class, but I would leave this for follow-up work as this class is internal, so can be adapted easily, and I don't want to defer a merge of this functionality. Things I would consider to make the class more maintainable are at least:
- Separate the UI setup from the controller logic
- Maybe extract layouting functionality (which parts of the UI to show and where to place them) into a separate class
- Update UI elements via listeners on the FindReplaceLogicState rather than making interactions with one UI element change the enablement of another
The text was updated successfully, but these errors were encountered:
@Wittmaxi using the eclipse sideffects is a quite powerful way to address the
Update UI elements via listeners on the FindReplaceLogicState rather than making interactions with one UI element change the enablement of another
Basically it works like this:
Use WidgetSideEffects to create a factory
Use WidgetProperties to wrap interesting properties you like to observe into IObvervables
now create a side-effect and instead of query e.g. the checked state of the widget use the IObvervable equivalent and update the control you like accordingly
That way as soon as anything you have accessed will update it immediately without further thinking about listeners and states.
This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal
comment by @HeikoKlare
The text was updated successfully, but these errors were encountered: