Dependency Updates

[eclipse-releng-bot]

Please review the changes and merge if appropriate, or cherry pick individual updates.

[merks]

It looks like the license check is failing

Error:  Cannot resolve project dependencies:
Error:    Software being installed: org.eclipse.tips.ide 0.3.500.qualifier
Error:    Missing requirement: com.google.gson 2.12.0 requires 'java.package; com.google.errorprone.annotations [2.36.0,3.0.0)' but it could not be found
Error:    Cannot satisfy dependency: org.eclipse.tips.ide 0.3.500.qualifier depends on: osgi.bundle; org.eclipse.tips.json 0.0.0
Error:    Cannot satisfy dependency: org.eclipse.tips.json 0.3.400.qualifier depends on: osgi.bundle; com.google.gson 0.0.0

because this additional is needed:

        <dependency>
          <groupId>com.google.errorprone</groupId>
          <artifactId>error_prone_annotations</artifactId>
          <version>2.36.0</version>
          <type>jar</type>
        </dependency>

I wonder if that dependency was intentionally introduced...

[iloveeclipse]

I wonder if that dependency was intentionally introduced...

Probably not, as usually these annotations are only needed for compilation but not at runtime, but who knows...

[laeubi]

I wonder if that dependency was intentionally introduced...

I don't think so, annotations should either be not imported (e.g. only source or class retention) or imported optional (e.g. runtime retention).

[merks]

I already updated Orbit. Maybe I should back level this back out of Orbit before it ends up in a milestone.

[laeubi]

See

• Make annotations class retention only google/error-prone#4797
• Only import errorprone.annotations with optional (if at all) google/gson#2794

as gson is in "maintenance mode" I'm not sure if something happens without providing a PR, also not sure how early we can expect a new release.

[merks]

So what action will the Platform take on this issue? I need to know what to do in Orbit...

[merks]

BTW, I think it might be intentional because they do export an "annotations" package even in the older version:

[iloveeclipse]

because they do export an "annotations" package even in the older version

That is not same as com.google.errorprone.annotations

[merks]

Yes, of course it's not. I'm just highlighting the changes from the previous version and the new version. I see no uses declaration for packages that might come from that new dependency...

[iloveeclipse]

I believe including error_prone_annotations in platform is OK, it shouldn't have other dependencies.
I see that jgit & tm4e use com.google.gson and I guess they will fail to build too if error_prone_annotations is not there.

[merks]

Not much depends on error_prone_annotations but a lot of things depend on gson:

[laeubi]

See

• Make the import of com.google.errorprone optional google/gson#2795

[iloveeclipse]

2.12.1 with the fixed dependency is released

[merks]

That took quite some convincing. Thanks guys!

[merks]

It looks like this now: