Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator: error on creating top-level aggregators #953

Closed
eparovyshnaya opened this issue Nov 18, 2021 · 1 comment · Fixed by #1279
Closed

Operator: error on creating top-level aggregators #953

eparovyshnaya opened this issue Nov 18, 2021 · 1 comment · Fixed by #1279
Assignees
@eparovyshnaya
Labels
component::operator (obsolete) Eclipse Passage Operator RCP (LOC)
Milestone
2.11.0

Comments

@eparovyshnaya
Copy link
Contributor

eparovyshnaya commented Nov 18, 2021 •
edited
Loading

Create Feature Set or Product Line: after a creatig dialog is 'finished', there is an error in console:

----------------------------------
!ENTRY org.eclipse.passage.loc.features.core 2 0 2020-11-17 17:50:25.479
!MESSAGE Duplication of feature instances. The existing instance: "org.eclipse.passage.lic.features.model.impl.FeatureSetImpl@71ee2fff (identifier: samples.feature.set, name: Samples Feature Set, description: null)" will be replaced by: "org.eclipse.passage.lic.features.model.impl.FeatureSetImpl@68f2363 (identifier: samples.feature.set, name: Samples Feature Set, description: null)" 
----------------------------------

Version: 1.1.0
Ported from bugs.eclipse.org: 568895

Created entities are unoperable: child can be added, but cannot be edited
@eparovyshnaya eparovyshnaya added the component::operator (obsolete) Eclipse Passage Operator RCP (LOC) label Nov 18, 2021
@eparovyshnaya
Copy link
Contributor Author

Ported comment Elena Parovyshnaia 2020-11-18 00:54:13 EST

RootClassifierWizard::protected void store(String path, EObject candidate)
does pretty straightforward things:

------------------------------------------------------------
1                URI fileURI = URI.createFileURI(path);
2		Resource resource = resourceSet().createResource(fileURI);
3		resource.getContents().add(candidate);
4		LocWokbench.save(resource);
5		registry.registerSource(fileURI.toFileString());
------------------------------------------------------------

Line 3 causes XMIResource-replenichment notification firing, which ends up in FeatureDomainRegistry::registerFeatureSet call

Line 5 triggers XMIResource-load, which also leads to this FeatureDomainRegistry::registerFeatureSet

Should we clean the FeatureDomainRegistry::featureSetIndex prior XMIResource-load?

Eitherway, this error looks cosmetic and does not actually causes the effects described in this issue.

@eparovyshnaya eparovyshnaya added this to the 2.11.0 milestone Feb 15, 2024
eparovyshnaya pushed a commit that referenced this issue Feb 15, 2024
[#953] Operator: error on creating top-level aggregators
6901bdd
eparovyshnaya added a commit that referenced this issue Feb 15, 2024
@eparovyshnaya
[#953] Operator: error on creating top-level aggregators
96d2527
@eparovyshnaya eparovyshnaya mentioned this issue Feb 15, 2024
Merged
eparovyshnaya added a commit that referenced this issue Feb 15, 2024
@eparovyshnaya
[#953] Operator: error on creating top-level aggregators
a6cd7da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eparovyshnaya eparovyshnaya

Labels
component::operator (obsolete) Eclipse Passage Operator RCP (LOC)
Projects
None yet
Milestone
2.11.0
Development

Successfully merging a pull request may close this issue.

[#953] Operator: error on creating top-level aggregators eclipse-passage/passage
2 participants
@eparovyshnaya @ruspl-afed