-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLS] Provide mean to obtain the address of the remote that send a request #1260
Comments
Dear @HannesWell Eclipse Passage FLS was designed and implemented as a demo product to illustrate Eclipse Passage power. This statement is really important to keep in mind during any discussions regarding the product. Any changes to FLS in the current product form-factor (demo) must serve this purpose. Meaning, if FLS eventually stops doing demonstration because of a disfunction, then changes fixing this disfunctions are welcome. Like recent #1258. Change you requested does not serve main purpose of FLS, just lays additional burden without any benefit to the product. Been that said, it worth mentioning that despite FLS was never intended to grow to a fully functional or/and reusable product, it can be productized to this grade with a proper effort. We estimate effort to be several man-months, which we can dedicate, if supported. |
Thank you @eparovyshnaya for your elaboration.
That's right.
While it would be nice to have fully productization of the FLS it would not be worth the effort for us since the current state is sufficient for us and I can also achieve this on other (of course less clean and elegant) ways and I'm happy to contribute from time to time when there is some need. |
Thank you for information @HannesWell . Then I'm closing the ticket. We are looking forward for further collaboration. |
Within a handler passed to passage's FLS JettyHandler it can be of interest to know the sender of a request, e.g. to log it:
With a
org.eclipse.jetty.server.Request
one can useRequest.getRemoteAddr(jettyRequest)
to obtain that information, as suggested in #1259.But neither
NetRequest
or itsJettyRequest
implementation provide access to the original Request and Passage'sJettyServer
andJettyHandler
are not extensible and therefore do not allow to use a custom/extendedJettyRequest
(which is also final).An extension that grants access to the original Jetty Request probably gives the greatest flexibility and would therefore be welcome.
The simplest way would be to provide an getter for the origin field of the
JettyRequest
.The text was updated successfully, but these errors were encountered: