-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 0.10.0 #2766
Release notes for 0.10.0 #2766
Conversation
@pshipton For some reason I thought we were removing the list of functional tests in 0.9.0 but they are still there. Let me know if you want them taken out of 0.9.0 and/or 0.10.0. I'm sure there is a lot more to go in here but we have a starting position. |
I'm ok to remove the list of open test failures from the release notes. They aren't necessarily just functional test failures, I see at least 3 system test failures in the list for 0.9.0. |
5843fae
to
10e1932
Compare
Looks basically ok to me. Under "Notable changes in this release", I notice there's nothing about JDK 11 features. Maybe we should have at least a short list of the JDK11 JEPs that make an appearance in OpenJ9 0.10.0? Normally, one would expect the updates you're making to the 0.9.0 release notes to go into a separate commit from the commit creating the 0.10.0 release notes. |
I can add the JEPs. Looking at the issues list I see 8 for JDK 11.
@pshipton - is this accurate please? Just 181 and 323 for the release notes. I can put the 0.9.0 changes into another commit. |
10e1932
to
c2a92bb
Compare
@SueChaplain |
Also note there are JEPs in Java 11 OpenJDK which don't require anything from OpenJ9 http://openjdk.java.net/projects/jdk/11/ |
6dbc514
to
27fd75c
Compare
doc/release-notes/0.10/0.10.md
Outdated
<tr><td valign="top"><a href="https://github.com/eclipse/openj9/issues/479">#479</a></td> | ||
<td valign="top">Non-compressed references VM builds not available</td> | ||
<td valign="top">AIX, Windows, Linux on Z, Linux on Power</td> | ||
<td valign="top">Heaps larger than 57GB are not supported.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be re-worded. They are supported, at least on Linux on X, and should work on all other platforms if built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a go at re-wording. Let me know if you want changes.
doc/release-notes/0.10/0.10.md
Outdated
</tr> | ||
|
||
<tr><td valign="top"><a href="https://github.com/ibmruntimes/openj9-openjdk-jdk8/issues/17">#17</a></td> | ||
<td valign="top">Builds contain extra shared libraries.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only applies to Java 8 (and 10) now. The issue is resolved for Java 11 (and 0.10.0 is a Java 11 only release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
fyi @SueChaplain you can use keywords to auto-close the issue when the PR is merged. I've already changed it. |
27fd75c
to
4377257
Compare
doc/release-notes/0.10/0.10.md
Outdated
|
||
- [OpenJDK version 11](https://adoptopenjdk.net/nightly.html?variant=openjdk11&jvmVariant=openj9) | ||
|
||
Builds are tested against the OpenJ9 functional verification (FV) test suite, the OpenJDK test suites, and additional tests at AdoptOpenJDK. At this stage the builds are compatible, but not compliant with OpenJDK 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but not compliant with OpenJDK 11
. This isn't an OpenJ9 statement. Compliance is tracked with the "blue checkmark" at Adopt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
4377257
to
6747db8
Compare
doc/release-notes/0.10/0.10.md
Outdated
<tr><td valign="top"><a href="https://github.com/eclipse/openj9/issues/479">#479</a></td> | ||
<td valign="top">Non-compressed references VM builds not available</td> | ||
<td valign="top">AIX, Windows, Linux on Z, Linux on Power</td> | ||
<td valign="top">Non-compressed references VM builds, which support heaps larger than 57GB are supported on Linux on x86. Non-compressed references builds for other platforms are not available at AdoptOpenJDK.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't like the wording. As @DanHeidinga pointed out elsewhere, "not available at AdoptOpenJDK" is an Adopt statement, not OpenJ9. From an OpenJ9 point of view, non-compressed refs is supported for all platforms, but only tested nightly for Linux x86.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why we have this as a limitation at all. Perhaps I should just remove it? Or do you want a statement that we are not testing the other platforms? If someone builds it and finds a problem I'm guessing that we would help fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its more like a FAQ than limitation but we could just say "Non-compressed references VM builds, which support heaps larger than 57GB, are built on Linux on x86." Which keeps the info about manual builds for other platforms.
d7ba938
to
1293613
Compare
The final release tags for 0.10.0 have been created. |
doc/release-notes/0.10/0.10.md
Outdated
|
||
## Binaries and supported environments | ||
|
||
This release adds compatibility with OpenJDK v11. We expect a binary of OpenJDK 11 with OpenJ9 to be available from the AdoptOpenJDK community in the near future at the following link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this statement should be updated since the link is now active. Also I'm wondering if this should link to the actual release page when it is created.
1293613
to
c417749
Compare
To support the upcoming 0.10.0 release for issue eclipse-openj9#2765 Modifications made to the 0.9.0 release notes to add and fix some links to binaries at AdoptOpenJDK. [skip-ci] Signed-off-by: Sue Chaplain <[email protected]>
c417749
to
20f4460
Compare
To support the upcoming 0.10.0 release for
fixes #2765
Modifications made to the 0.9.0 release notes
to add and fix some links to binaries at AdoptOpenJDK.
Signed-off-by: Sue Chaplain [email protected]