(0.48) Fix overflow issues #20363
Merged
(0.48) Fix overflow issues #20363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncate length while evaluating length of a UTF-8 string - On 32-bit systems, the length is truncated to UDATA_MAX. - For JNI getStringUTFLength, the length is truncated to INT32_MAX. Add restrictions while copying a string to UTF-8 to avoid overflow - The length is restricted to UDATA_MAX to accommodate memory allocation functions, which take a UDATA as the input parameter for length. - The data is stopped from being written to the UTF-8 buffer if its length will be exceeded. Signed-off-by: Babneet Singh <[email protected]>
keithc-ca
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20362
Background
See https://bugs.openjdk.org/browse/JDK-8338709 and https://bugs.openjdk.org/browse/JDK-8328877.
Implementation
Truncate length while evaluating length of a
UTF-8stringUDATA_MAX.getStringUTFLength, the length is truncated toINT32_MAX.Add restrictions while copying a string to
UTF-8to avoid overflowUDATA_MAXto accommodate memory allocationfunctions, which take a
UDATAas the input parameter for length.UTF-8buffer if itslength will be exceeded.
Signed-off-by: Babneet Singh [email protected]