Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max TLH for non-batch clear platforms #19936

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

amicic
Copy link
Contributor

@amicic amicic commented Jul 30, 2024

For non-batch TLH clear platform (currently only those based on X h/w) the maximum size is increased to 1MB (from 128K default set by OMR). This allows better scaling on high allocating/high CPU count configurations.

Batch clearing platforms stays at 128K max, since clearing too much in a batch may flush useful data from CPU data caches.

@amicic amicic added the comp:gc label Jul 30, 2024
@amicic amicic force-pushed the maxTLH_noBatchClear branch 2 times, most recently from 51dd0c3 to 1d52cbe Compare July 30, 2024 15:41
@dmitripivkine
Copy link
Contributor

Jenkins test sanity xLinux,aix jdk21

@amicic
Copy link
Contributor Author

amicic commented Jul 30, 2024

Jenkins test sanity xLinux jdk21

@dmitripivkine
Copy link
Contributor

Jenkins test sanity xLinux jdk11

@amicic
Copy link
Contributor Author

amicic commented Jul 30, 2024

resolved conflicts

For non-batch TLH clear platform (currently only those based on X h/w)
the maximum size is increased to 1MB (from 128K default set by OMR).
This allows better scaling on high allocating/high CPU count
configurations.

Batch clearing platforms stays at 128K max, since clearing too much in a
batch may flush useful data from CPU data caches.

Signed-off-by: Aleksandar Micic <[email protected]>
@amicic
Copy link
Contributor Author

amicic commented Jul 30, 2024

corrected usage of batchClearTLH (treating it as an int, rather than as a bool)

@amicic
Copy link
Contributor Author

amicic commented Jul 31, 2024

Jenkins test sanity xLinux,aix jdk21

@amicic
Copy link
Contributor Author

amicic commented Jul 31, 2024

Jenkins test sanity xLinux jdk11

@dmitripivkine
Copy link
Contributor

Failure in Build_JDK21_x86-64_linux is no space on disk. Merging.

@dmitripivkine dmitripivkine merged commit 07797d6 into eclipse-openj9:master Jul 31, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants