-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase max TLH for non-batch clear platforms #19936
Merged
dmitripivkine
merged 1 commit into
eclipse-openj9:master
from
amicic:maxTLH_noBatchClear
Jul 31, 2024
Merged
Increase max TLH for non-batch clear platforms #19936
dmitripivkine
merged 1 commit into
eclipse-openj9:master
from
amicic:maxTLH_noBatchClear
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
force-pushed
the
maxTLH_noBatchClear
branch
2 times, most recently
from
July 30, 2024 15:41
51dd0c3
to
1d52cbe
Compare
dmitripivkine
approved these changes
Jul 30, 2024
amicic
force-pushed
the
maxTLH_noBatchClear
branch
from
July 30, 2024 15:51
1d52cbe
to
4c2f109
Compare
Jenkins test sanity xLinux,aix jdk21 |
Jenkins test sanity xLinux jdk21 |
Jenkins test sanity xLinux jdk11 |
resolved conflicts |
For non-batch TLH clear platform (currently only those based on X h/w) the maximum size is increased to 1MB (from 128K default set by OMR). This allows better scaling on high allocating/high CPU count configurations. Batch clearing platforms stays at 128K max, since clearing too much in a batch may flush useful data from CPU data caches. Signed-off-by: Aleksandar Micic <[email protected]>
amicic
force-pushed
the
maxTLH_noBatchClear
branch
from
July 30, 2024 23:55
7274905
to
9574f68
Compare
corrected usage of batchClearTLH (treating it as an int, rather than as a bool) |
Jenkins test sanity xLinux,aix jdk21 |
Jenkins test sanity xLinux jdk11 |
Failure in Build_JDK21_x86-64_linux is no space on disk. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-batch TLH clear platform (currently only those based on X h/w) the maximum size is increased to 1MB (from 128K default set by OMR). This allows better scaling on high allocating/high CPU count configurations.
Batch clearing platforms stays at 128K max, since clearing too much in a batch may flush useful data from CPU data caches.