(0.46.0) Skip zero-init, checks for some BigInteger methods #19603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysun-omr
approved these changes
Jun 3, 2024
|
The original change is causing failures in the IBM Java 8 builds, which needs to be resolved before this is added to 0.46. |
|
Will wait until we get an update on the reported failure |
This patch recognizes the following BigInteger methods: * BigInteger.BigInteger(long): void * BigInteger.toByteArray(): byte[] * BigInteger.stripLeadingZeroBytes(byte[], int, int): int[] * BigInteger.stripLeadingZeroBytes(int, byte[], int, int): int[] and skips array zero-initialization, NULL, and bounds checks in these methods. Signed-off-by: Younes Manton <[email protected]> Skip BigInteger zero-init & checks for OpenJ9 only The BigInteger.toByteArray implementation in OpenJ9 doesn't depend on zero-initialization and it is currently safe to skip that operation in that context. The Apache Harmony BigInteger implementation relies on zero-init and returns the wrong result without it. This patch limits skipping of zero-init (and NULL and bounds checks, to be conservative) for BigInteger.toByteArray to OpenJ9 builds. Signed-off-by: Younes Manton <[email protected]>
ymanton
force-pushed
the
skip-zeroinit-checks-bigint-0.46
branch
from
dabec97
to
b8655d4
Compare
|
Since the fix doesn't affect OpenJ9 builds, I assume this can be merged as-is. |
|
Yes, shouldn't affect OpenJ9, but I just happened to squash the fix on top just before your comment anyway. |
vijaysun-omr
approved these changes
Jun 3, 2024
|
Corresponding OpenJ9 head stream change is merged now since the relevant tests seem to be passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch recognizes the following BigInteger methods:
and skips array zero-initialization, NULL, and bounds checks in these methods.
Cherry-picked from #19556