cacheDirPerm should be set if -Xshareclasses is not specified #19539
Conversation
SCC is enabled by default when -Xshareclasses is not specified in the CML. cacheDirPerm should be set to J9SH_DIRPERM_ABSENT in this case. Closes eclipse-openj9#19328 Signed-off-by: Hang Shao <[email protected]>
|
While looking at this, I noticed some documentation error regarding |
|
@pshipton, I intended to cherry pick this change to my personal fork of v0.46 branch and create a new pull request to back port to 0.46. However, I accidentally pushed this change directly to https://github.com/eclipse-openj9/openj9/commits/v0.46.0-release/. Should I revert that or let it be the way it is now ? |
|
I don't think we can create a PR to deliver the same change? If not, we can directly push a revert and then open the PR. We want a PR so the change shows up in the release notes. |
|
Start from a commit which isn't the latest, such as 2da7e0a283, cherry pick the change on top, and then create a PR from that. Example https://github.com/eclipse-openj9/openj9/compare/v0.46.0-release...pshipton:test2?expand=1 |
PR for 0.46: #19567. |
SCC is enabled by default when -Xshareclasses is not specified in the CML. cacheDirPerm should be set to J9SH_DIRPERM_ABSENT in this case.
Closes #19328