Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GC_TLH_PREFETCH_FTA flag settings in cmake files #18918

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 8, 2024

This commit removes redundant OMR_GC_TLH_PREFETCH_FTA lines from cmake files for some platforms.
OMR_GC_TLH_PREFETCH_FTA is automatically defined in omrcfg.h during the build depending on J9VM_GC_TLH_PREFETCH_FTA value.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 8, 2024

Jenkins test sanity all jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Feb 8, 2024

See Issue #18870 for the background information.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 8, 2024

Jenkins test sanity xlinux,xmac jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Feb 8, 2024

Jenkins line endings check

@knn-k knn-k marked this pull request as ready for review February 8, 2024 23:07
This commit removes redundant OMR_GC_TLH_PREFETCH_FTA lines from cmake
files for some platforms.
OMR_GC_TLH_PREFETCH_FTA is automatically defined in omrcfg.h during the
build depending on J9VM_GC_TLH_PREFETCH_FTA value.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k
Copy link
Contributor Author

knn-k commented Feb 9, 2024

Jenkins test sanity plinux,win,xlinux,xmac jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Feb 9, 2024

This PR does not change the flag settings on any platform. OMR_GC_TLH_PREFETCH_FTA in cmake files is useless.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 9, 2024

Jenkins test sanity xmac jdk17

Re-running xmac test as it failed with the following message:

fatal: unable to access 'https://github.com/adoptium/aqa-tests.git/': gnutls_handshake() failed: The TLS connection was non-properly terminated.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 9, 2024

Jenkins test sanity xlinux jdk17

Re-running xlinux test as it failed in cmdLineTester_criu_nonPortableRestore_5 with the following message:

FAILED: testTimeCompensation() preCheckpoint timer delayed 4s elapsedMillisTime (4001ms) should NOT be less than minElapsedMillisTime (6000ms)

It looks similar to Issue #18471.
Assuming it is not a failure caused by this PR.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 11, 2024

Jenkins test sanity win jdk17

Re-runnning Windows test. The previous job failed due to timeout, waiting too long in the queue.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 15, 2024

Summary:

  • x86 platforms: J9VM_GC_TLH_PREFETCH_FTA is ON. Remove the unused OMR_GC_TLH_PREFETCH_FTA line.
  • linux_ppc-64_le: J9VM_GC_TLH_PREFETCH_FTA is ON. Remove the contradicting and unused OMR_GC_TLH_PREFETCH_FTA line.
  • zos_390-64: J9VM_GC_TLH_PREFETCH_FTA is OFF. Remove the unused OMR_GC_TLH_PREFETCH_FTA line.

@dmitripivkine
Copy link
Contributor

Please note GC part of the code rely on OMR_GC_TLH_PREFETCH_FTA to be set properly.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 15, 2024

@dmitripivkine OMR_GC_TLH_PREFETCH_FTA is set properly in omrcfg.h based on J9VM_GC_TLH_PREFETCH_FTA value, as stated in the commit message. The OMR_GC_TLH_PREFETCH_FTA lines in .cmake files are ignored, and it is safe to remove those lines.

j9vm_shadowed_option() in runtime/cmake/options.cmake does the work:

# creates an option which shadows an omr option of the same/similar name
# j9vm_shadowed_option(<j9_name> [<omr_name>] <help_text>)
# create a new option named <j9_name>. This option will override the value
# of <omr_name>. If <omr_name> is not supplied it defaults to <j9_name>
# with the leading 'J9VM_' replaced with 'OMR_'
function(j9vm_shadowed_option j9_opt_name)

j9vm_shadowed_option(J9VM_GC_TLH_PREFETCH_FTA "Enable tlhPrefetchFTA")

@pshipton pshipton merged commit 3f3daa3 into eclipse-openj9:master Feb 23, 2024
11 checks passed
@knn-k knn-k deleted the tlhPrefetchFlags branch February 24, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants