Support interpreter re-entry for CRIU debug support #18903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new private flag which instructs the interpreter to exit and re-invoke itself. This will be used by CRIU when a restored image requests debug capabilities (by changing the interpreter entry point to the debug interpreter). Related: eclipse-openj9#17642 Signed-off-by: Graham Chapman <[email protected]>
|
Use |
tajila
approved these changes
Feb 6, 2024
|
jenkins test sanity win jdk8 |
|
jenkins test sanity plinux jdk21 |
keithc-ca
reviewed
Feb 7, 2024
| @@ -49,6 +49,8 @@ FUNC_LABEL(cInterpreter): | |||
| blr x28 | |||
| cmp x0, {#}J9TR_bcloop_exit_interpreter | |||
| beq .L_cInterpExit | |||
| cmp x0, {#}J9TR_bcloop_reenter_interpreter | |||
| beq FUNC_LABEL(cInterpreter | |||
There was a problem hiding this comment.
Missing closing parenthesis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new private flag which instructs the interpreter to exit and re-invoke itself. This will be used by CRIU when a restored image requests debug capabilities (by changing the interpreter entry point to the debug interpreter).
Related: #17642