Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send AOT header to server whenever JITServer AOT cache is requested #18889

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

cjjdespres
Copy link
Contributor

@cjjdespres cjjdespres commented Feb 4, 2024

A client will now send a TR_AOTHeader as part of its VM info whenever the AOT cache as been requested to be used. As we currently only create and enable the deserializer with a local SCC present, this should not change any current behaviour.

The new TR_RelocationRuntime::fillAOTHeader is responsible for filling in a new TR_AOTHeader. Actual allocation of this header is still handled by TR_SharedCacheRelocationRuntime::createAOTHeader.

@cjjdespres
Copy link
Contributor Author

cjjdespres commented Feb 4, 2024

Attn @mpirvu.

The new TR_RelocationRuntime::fillAOTHeader is responsible for
filling in a new TR_AOTHeader. Actual allocation of this header is
still handled by TR_SharedCacheRelocationRuntime::createAOTHeader.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres cjjdespres changed the title Move AOT header filling to base relo runtime Send AOT header to server whenever JITServer AOT cache is requested Feb 5, 2024
@cjjdespres
Copy link
Contributor Author

Force-pushed and changed the PR topic slightly because I thought it might be easier to have the entire header-sending change in one merge.

@cjjdespres
Copy link
Contributor Author

Force-pushed to bring in the latest merges. Shouldn't have changed anything.

@mpirvu mpirvu self-assigned this Feb 7, 2024
@mpirvu mpirvu added comp:jit:aot comp:jitserver Artifacts related to JIT-as-a-Service project labels Feb 7, 2024
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Feb 7, 2024

jenkins test sanity all jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Feb 7, 2024

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2024

jenkins test sanity alinux,alinux64jit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2024

jenkins test sanity alinux,alinux64jit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2024

The failure on ARM was due to infra, so I triggered another round of testing.

20:21:54  Cloning into 'openj9'...
20:21:55  update to openj9 sha: origin/pr/18889/merge
20:21:55  git fetch -q --unshallow
20:22:28  error: pathspec 'origin/pr/18889/merge' did not match any file(s) known to git
20:22:28  SHA not yet found. Continue fetching PR refs and tags...
20:22:28  git fetch -q --tags https://github.com/eclipse-openj9/openj9.git +refs/pull/*:refs/remotes/origin/pr/*
20:22:54  error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
20:22:54  error: 2295 bytes of body are still expected
20:22:54  fetch-pack: unexpected disconnect while reading sideband packet
20:22:54  fatal: early EOF
20:22:54  fatal: fetch-pack: invalid index-pack output

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2024

The test on aarch64 failed due to infra:

20:21:54  git clone --depth 1 --reference-if-able /home/****/openjdk_cache -b master https://github.com/eclipse-openj9/openj9.git
20:21:54  Cloning into 'openj9'...
20:21:55  update to openj9 sha: origin/pr/18889/merge
20:21:55  git fetch -q --unshallow
20:22:28  error: pathspec 'origin/pr/18889/merge' did not match any file(s) known to git
20:22:28  SHA not yet found. Continue fetching PR refs and tags...
20:22:28  git fetch -q --tags https://github.com/eclipse-openj9/openj9.git +refs/pull/*:refs/remotes/origin/pr/*
20:22:54  error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
20:22:54  error: 2295 bytes of body are still expected
20:22:54  fetch-pack: unexpected disconnect while reading sideband packet
20:22:54  fatal: early EOF
20:22:54  fatal: fetch-pack: invalid index-pack output

Since other tests have passed (including one of aarch64) I am merging this PR.

@mpirvu mpirvu merged commit 59b659a into eclipse-openj9:master Feb 8, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit:aot comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants