-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send AOT header to server whenever JITServer AOT cache is requested #18889
Send AOT header to server whenever JITServer AOT cache is requested #18889
Conversation
Attn @mpirvu. |
The new TR_RelocationRuntime::fillAOTHeader is responsible for filling in a new TR_AOTHeader. Actual allocation of this header is still handled by TR_SharedCacheRelocationRuntime::createAOTHeader. Signed-off-by: Christian Despres <[email protected]>
8c776de
to
f323cac
Compare
Signed-off-by: Christian Despres <[email protected]>
f323cac
to
11216da
Compare
Force-pushed and changed the PR topic slightly because I thought it might be easier to have the entire header-sending change in one merge. |
Force-pushed to bring in the latest merges. Shouldn't have changed anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test sanity all jdk21 |
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17 |
jenkins test sanity alinux,alinux64jit jdk17 |
jenkins test sanity alinux,alinux64jit jdk21 |
The failure on ARM was due to infra, so I triggered another round of testing.
|
The test on aarch64 failed due to infra:
Since other tests have passed (including one of aarch64) I am merging this PR. |
A client will now send a
TR_AOTHeader
as part of its VM info whenever the AOT cache as been requested to be used. As we currently only create and enable the deserializer with a local SCC present, this should not change any current behaviour.The new TR_RelocationRuntime::fillAOTHeader is responsible for filling in a new TR_AOTHeader. Actual allocation of this header is still handled by TR_SharedCacheRelocationRuntime::createAOTHeader.