Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dark matter before determining classes to recreate #18752

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Eliminate dark matter before determining classes to recreate #18752

merged 1 commit into from
Jan 13, 2024

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Jan 12, 2024 •
edited
Loading

Eliminating dark matter before determining classes to recreate prevents
dying and unloaded classes to be encountered while recreating RAM
classes.

Related: #18750

@babsingh babsingh marked this pull request as draft January 12, 2024 17:51
@babsingh babsingh mentioned this pull request Jan 12, 2024
Closed
@babsingh babsingh marked this pull request as ready for review January 12, 2024 17:52
@tajila
Copy link
Contributor

tajila commented Jan 12, 2024

I wonder if we can just do the GC before calling determineClassesToRecreate

@babsingh
Eliminate dark matter before determining classes to recreate
dfb74f5 
Eliminating dark matter before determining classes to recreate prevents
dying and unloaded classes to be encountered while recreating RAM
classes.

Related: eclipse-openj9#18750

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh changed the title Do not recreate a RAM class if the class is dying and unloaded Eliminate dark matter before determining classes to recreate Jan 12, 2024
@babsingh
Copy link
Contributor Author

I wonder if we can just do the GC before calling determineClassesToRecreate

This will be better. determineClassesToRecreate only finds all the classes for recreation, and no new dark matter should be created since we have safepoint/exclusive VM access. Updated the PR to reflect this suggestion, and verified that the failure is resolved.

@tajila
Copy link
Contributor

tajila commented Jan 12, 2024

jenkins test sanity alinux64 jdk21

@gacholio
Copy link
Contributor

This is exactly what I had in mind - I'll take a proper look tomorrow.

@gacholio gacholio merged commit ed3e662 into eclipse-openj9:master Jan 13, 2024
5 checks passed
@babsingh babsingh mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gacholio gacholio gacholio approved these changes

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babsingh @tajila @gacholio @pshipton