Reduce counts only for implict SCC #18726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR eclipse-openj9#18356 introduced a change to reduce the counts of a method whose class is not in the shared class cache (SCC), if SCC is enabled and the load of that class happens during start-up. This change improves performance of some short running benchmarks from the DaCapo suite (when run with default options), but was discovered to also cause a small (2-3%) throughput regression when running the Daytrader benchmark on top of tWAS. This commit restricts the change from PR eclipse-openj9#18356 to environments that use an implicit SCC (by default, OpenJ9 creates an implict SCC that is only allowed to to store bootstrap classes). Signed-off-by: Marius Pirvu <[email protected]>
|
jenkins test sanity zlinux jdk17 |
|
Attn @vijaysun-omr |
vijaysun-omr
approved these changes
Jan 11, 2024
|
Looks pretty safe to me. I can merge after @dsouzai has taken a look as well. |
dsouzai
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18356 introduced a change to reduce the counts of a method whose class is not in the shared class cache (SCC), if SCC is enabled and the load of that class happens during start-up. This change improves performance of some short running benchmarks from the DaCapo suite (when run with default options), but was discovered to also cause a small (2-3%) throughput regression when running the Daytrader benchmark on top of tWAS.
This commit restricts the change from PR #18356 to just environments that use an implicit SCC (by default, OpenJ9 creates an implict SCC that is only allowed to to store bootstrap classes).