Use correct GC flag in HCR dark matter cleanup #18540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current flag does nothing - use the flag that's used in other similar callers throughout the VM. Fixes: eclipse-openj9#18482 Signed-off-by: Graham Chapman <[email protected]>
|
jenkins test sanity win,aix jdk11 |
amicic
approved these changes
Dec 1, 2023
This was referenced Dec 1, 2023
jdmpapin
reviewed
Dec 7, 2023
| /* J9MMCONSTANT_EXPLICIT_GC_RASDUMP_COMPACT allows the GC to run while the current thread is holding | ||
| * exclusive VM access. | ||
| */ | ||
| vm->memoryManagerFunctions->j9gc_modron_global_collect_with_overrides(currentThread, J9MMCONSTANT_EXPLICIT_GC_RASDUMP_COMPACT); |
There was a problem hiding this comment.
I don't understand how this change has any effect. Both of these are defined as 2
There was a problem hiding this comment.
Ops, we did not realize that.
In fact, in a discussion, I stated one could alias to the other, without realizing it's effectively already the case.
There was a problem hiding this comment.
prepared a fix based on it and confirmed it fixes the problem: #18606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flag does nothing - use the flag that's used in other similar callers throughout the VM.
Fixes: #18482