Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(0.43) Configure the wait time for checkpoint safety #18529

Merged
merged 5 commits into from
Dec 8, 2023
Merged

(0.43) Configure the wait time for checkpoint safety #18529

merged 5 commits into from
Dec 8, 2023

Commits on Dec 5, 2023

  1. Increase the wait time for checkpoint safety 

    Increase the wait time for checkpoint safety from 1 ms
to 2 s for threads initializing a class, and fix the
failure in the re-enabled MethodTypeDeadlockTest that
occurs due to an insufficient wait time for checkpoint
safety for threads initializing a class.

Issue: eclipse-openj9#15806
Signed-off-by: Amarpreet Singh <[email protected]>
    @singh264
    singh264 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ead77f4 View commit details
    Browse the repository at this point in the history

  2. Simplify the code 

    Simplify the code that increases the wait time for
checkpoint safety from 1 ms to 2 s by sleeping for a
fixed time per checkpoint safety check.

Issue: eclipse-openj9#15806
Signed-off-by: Amarpreet Singh <[email protected]>
    @singh264
    singh264 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    901a9d7 View commit details
    Browse the repository at this point in the history

  3. Add options to control the checkpoint safety wait time 

    Add -XX:maxRetryForNotCheckpointSafe= and
-XX:sleepMillisecondsForNotCheckpointSafe= to control the
checkpoint safety wait time for MethodTypeDeadlockTest.

Issue: eclipse-openj9#15806
Signed-off-by: Amarpreet Singh <[email protected]>
    @singh264
    singh264 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    62a5e4d View commit details
    Browse the repository at this point in the history

  4. Fix the race condition in MethodTypeDeadlockTest 

    Fix the race condition in MethodTypeDeadlockTest for the
shared resource testResult.lockStatus by modifying its
type from volatile int to AtomicInteger, and avoid the
test from timing out when the main thread is blocked
while waiting for testResult.lockStatus to reflect the
count of the worker threads that were started by the
main thread.

Issue: eclipse-openj9#15806
Signed-off-by: Amarpreet Singh <[email protected]>
    @singh264
    singh264 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    2864317 View commit details
    Browse the repository at this point in the history

  5. Disable criu_nonPortableRestore tests on s390x 

    Disable criu_nonPortableRestore tests on s390x due to the
limited number of s390x machines with proper CRIU setup.

Issue: eclipse-openj9#15806
Signed-off-by: Amarpreet Singh <[email protected]>
    @singh264
    singh264 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b58421e View commit details
    Browse the repository at this point in the history