Virtual Thread Support #18432
Merged
Virtual Thread Support #18432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves perf by saving the resources used to store and initialize these variable. Signed-off-by: Babneet Singh <[email protected]>
Return JVMTI_ERROR_THREAD_NOT_SUSPENDED if the thread was not suspended and was not the current thread. For virtual threads, VirtualThread.state is read and it is checked if JVMTI_VTHREAD_STATE_SUSPENDED is set in VirtualThread.state. This check is incorrect because JVMTI_VTHREAD_STATE_SUSPENDED represents an internal state at the Java level. It does not imply if the virtual thread is suspended through JVMTI. JVMTI NotifyFramePop is updated to check if the virtual thread is suspended through JVMTI. Signed-off-by: Babneet Singh <[email protected]>
VM is entered by the invocation of internalEnterVMFromJNI. VM is exited by the invocation of internalExitVMToJNI. VM is always entered before acquireVThreadInspector and enterVThreadTransitionCritical are invoked. In these functions, the goal can be achieved by just releasing and re-acquiring VM access. The new changes just release and re-acquire VM access instead of exiting and entering the VM. This has less overhead. Addresses: eclipse-openj9#18420 (comment) Signed-off-by: Babneet Singh <[email protected]>
|
@gacholio Requesting your review. This PR address your feedback from #18420 (comment), and a few other issues. |
gacholio
approved these changes
Nov 9, 2023
|
jenkins test sanity win jdk8 |
|
jenkins test sanity zlinux jdk21 |
|
@gacholio PR builds have unrelated failures. All testing passed, but the build failed with an infra issue:
Known failure seen twice: #18384. |
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Update acquireVThreadInspector and enterVThreadTransitionCritical
VM is entered by the invocation of
internalEnterVMFromJNI.VM is exited by the invocation of
internalExitVMToJNI.VM is always entered before
acquireVThreadInspectorandenterVThreadTransitionCriticalare invoked.In these functions, the goal can be achieved by just releasing
and re-acquiring VM access. The new changes just release and
re-acquire VM access instead of exiting and entering the VM.
This has less overhead.
Addresses: #18420 (comment)
2. Update error handling in JVMTI NotifyFramePop
Return
JVMTI_ERROR_THREAD_NOT_SUSPENDEDif the thread was notsuspended and was not the current thread.
For virtual threads,
VirtualThread.stateis read and it is checkedif
JVMTI_VTHREAD_STATE_SUSPENDEDis set inVirtualThread.state.This check is incorrect because
JVMTI_VTHREAD_STATE_SUSPENDEDrepresents an internal state at the Java level. It does not
imply if the virtual thread is suspended through JVMTI.
JVMTI NotifyFramePop is updated to check if the virtual thread
is suspended through JVMTI.
3. Remove unused variables in jvm.c
This improves perf by saving the resources used to store and
initialize these variable.
Signed-off-by: Babneet Singh [email protected]