Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt getCallerClass MH tests for ojdk11 MHs #18372

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Adapt getCallerClass MH tests for ojdk11 MHs #18372

merged 1 commit into from
Oct 31, 2023

Conversation

ThanHenderson
Copy link
Contributor

This patch addresses #14989 for ojdk11 MHs. Hidden Classes changed InjectedInvoker class signatures. This patch updates the test case to support pre-hidden-class signatures.

Signed-off-by: Nathan Henderson [email protected]

@ThanHenderson ThanHenderson mentioned this pull request Oct 30, 2023
Closed
@ThanHenderson
Copy link
Contributor Author

ping: @babsingh

@babsingh
Copy link
Contributor

jenkins test extended.functional plinuxojdk292 jdk8,jdk11

@babsingh
Copy link
Contributor

jenkins test extended.functional zlinux jdk11

@babsingh
Copy link
Contributor

https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_extended.functional_ppc64le_linux_ojdk292_Personal_testList_1/1/consoleFull

cmdLineTester_getCallerClassTests_0 failed in JDK11:

[2023-10-30T18:18:28.062Z]  [OUT] test_getCallerClass_Helper_MethodHandle_fromBootExtWithAnnotation: FAILED: return com.ibm.j9.getcallerclass.InjectedInvoker/0x0000000000000000
[2023-10-30T18:18:28.062Z]  [OUT] test_getCallerClass_Direct_MethodHandle_fromBootExtClassLoader: PASSED
[2023-10-30T18:18:28.062Z]  [OUT] test_getCallerClass_MethodHandle_ArgumentHelper: FAILED: return com.ibm.j9.getcallerclass.InjectedInvoker/0x0000000000000000

@ThanHenderson
Adapt getCallerClass MH tests for ojdk11 MHs
e41e8f3 
This patch addresses eclipse-openj9#14989 for ojdk11 MHs.
Hidden Classes changed InjectedInvoker class signatures. This patch
updates the test case to support pre-hidden-class signatures.

Signed-off-by: Nathan Henderson <[email protected]>
@babsingh
Copy link
Contributor

jenkins test extended.functional amac jdk11

@babsingh
Copy link
Contributor

jenkins test extended.functional alinuxojdk292 jdk11

@babsingh
Copy link
Contributor

jenkins test extended.functional zlinuxojdk292 jdk11

@babsingh
Copy link
Contributor

jenkins test extended.functional zlinux jdk11

@babsingh
Copy link
Contributor

babsingh commented Oct 31, 2023 •
edited
Loading

Merging.

  • amac failure is due to infra issues.
  • eca check has passed but it isn't reflected in the PR.
  • zLinux builds represent the primary testing; the failing test has passed in the zLinux builds.

@babsingh babsingh merged commit b4ecea9 into eclipse-openj9:master Oct 31, 2023
7 of 9 checks passed
@babsingh babsingh mentioned this pull request Nov 6, 2023
Merged
@ThanHenderson ThanHenderson added comp:vm jdk11 project:MH Used to track Method Handles related work labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
comp:vm jdk11 project:MH Used to track Method Handles related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThanHenderson @babsingh