-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implicit conversion causing truncation warnings #18269
Merged
0xdaryl
merged 1 commit into
eclipse-openj9:master
from
dylanjtuttle:constantConversion
Dec 14, 2023
Merged
Fix implicit conversion causing truncation warnings #18269
0xdaryl
merged 1 commit into
eclipse-openj9:master
from
dylanjtuttle:constantConversion
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zl-wang Could you review this when you get the chance? |
zl-wang
reviewed
Dec 5, 2023
dylanjtuttle
force-pushed
the
constantConversion
branch
from
December 6, 2023 14:59
76e1be3
to
b7999c7
Compare
dylanjtuttle
force-pushed
the
constantConversion
branch
from
December 6, 2023 15:06
b7999c7
to
fb1ba41
Compare
zl-wang
reviewed
Dec 6, 2023
Fix AIX/plinux warnings concerning constant values being implicitly converted from an unsigned to a signed type or from a larger to a smaller type which had the potential to cause truncation Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
constantConversion
branch
from
December 12, 2023 16:38
fb1ba41
to
07bd5ad
Compare
zl-wang
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins test sanity plinux,aix jdk17 |
Jenkins test sanity plinux,aix jdk17 |
0xdaryl
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AIX/plinux warnings concerning constant values being implicitly converted from an unsigned to a signed type or from a larger to a smaller type which had the potential to cause truncation.
This PR contributes to (but does not close) #14859