Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add areFlattenableValueTypesEnabled() for JIT #17413

Merged
merged 1 commit into from
May 17, 2023

Conversation

hangshao0
Copy link
Contributor

@hangshao0 hangshao0 commented May 16, 2023

#17394 has added new flag
J9VM_OPT_VALHALLA_FLATTENABLE_VALUE_TYPES for flattenable value types.
The value object code is under the existing J9VM_OPT_VALHALLA_VALUE_TYPES.
Add new API areFlattenableValueTypesEnabled() for JIT.

issue #17235

@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:vm comp:jit labels May 16, 2023
eclipse-openj9#17394 has added new flag
J9VM_OPT_VALHALLA_FLATTENABLE_VALUE_TYPES for flattenable value types.
The value object code is under the existing
J9VM_OPT_VALHALLA_VALUE_TYPES.
Add new API areFlattenableValueTypesEnabled() for JIT.

issue eclipse-openj9#17235

Signed-off-by: Hang Shao <[email protected]>
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding this API @hangshao0!

@tajila
Copy link
Contributor

tajila commented May 16, 2023

Jenkins test sanity,extended xlinuxval jdknext

@tajila
Copy link
Contributor

tajila commented May 16, 2023

Jenkins test sanity win jdk8

Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tajila
Copy link
Contributor

tajila commented May 17, 2023

JDK8 test failed to copy artificats, no actual test failures

@tajila tajila merged commit 3fbe09e into eclipse-openj9:master May 17, 2023
@hangshao0 hangshao0 deleted the valueObject branch September 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants