Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make j9javaaccessflags.h more readable #17785

Closed
theresa-m opened this issue Jul 13, 2023 · 4 comments · Fixed by #17984
Closed

Make j9javaaccessflags.h more readable #17785

theresa-m opened this issue Jul 13, 2023 · 4 comments · Fixed by #17984
Assignees
@theresa-m
Labels
comp:vm

Comments

@theresa-m
Copy link
Contributor

The constants in j9javaaccessflags.h are not organized in a way where it is obvious which bits are available for new entries. The suggestion in this issue is to reorganize these in a more manageable way.
@theresa-m theresa-m mentioned this issue Jul 13, 2023
Merged
@theresa-m theresa-m self-assigned this Jul 13, 2023
@theresa-m
Copy link
Contributor Author

@hangshao0 it looks like J9AccClassHasIdentity added in #16041 has the same flag value as J9AccSuper. Can you confirm if that's correct?

@theresa-m
Copy link
Contributor Author

The other odd one is that J9AccSynthetic appears to have been used in extraModifiers in early versions of Java and modifiers from Java 1.5
https://github.com/eclipse-openj9/openj9/blob/master/runtime/bcutil/ROMClassBuilder.cpp#L1302-L1306
I think it is safe to remove this from extraModifiers

@hangshao0
Copy link
Contributor

@hangshao0 it looks like J9AccClassHasIdentity added in #16041 has the same flag value as J9AccSuper. Can you confirm if that's correct?

Yes, see here that ACC_SUPER flag is repurposed to indicate identity classes.

@theresa-m theresa-m mentioned this issue Jul 13, 2023
Merged
@theresa-m
Copy link
Contributor Author

Thanks, I'll add a comment about that in the file.

@theresa-m theresa-m mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theresa-m theresa-m

Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove synthetic flag from extraModifiers theresa-m/openj9
2 participants
@theresa-m @hangshao0