-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConstantDynamic: Add tests for ConstantDynamic #1274
Comments
@smlambert @llxia Are you monitoring the jtreg tests in OpenJDK |
We are not monitoring the repo, but we do run them at AdoptOpenJDK, including starting to turn on the JDK10 tests, once all of them are enabled, we will have a better view of that set. |
ok, I see the jdk11 label is now on this... so dismiss my comment about looking for ConstantDynamic tests in the Jdk10 tests |
A part of this is being taken care of in #2870. |
Can this be closed, or is there more to do? |
I think there are more corner cases to cover:
and possibly other cases I've missed. This should stay open until we've added more testing or identified relevant tests for these cases in OpenJDK that can be run on OpenJ9. |
Andrew - "we need to ensure the unresolved and resolved cases are tested in the JIT for reference type dynamic constants as well as the various primitive typed dynamic constants to make sure the code is working correctly"
The text was updated successfully, but these errors were encountered: