Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstantDynamic: Add tests for ConstantDynamic #1274

Open
tajila opened this issue Feb 26, 2018 · 6 comments
Open

ConstantDynamic: Add tests for ConstantDynamic #1274

tajila opened this issue Feb 26, 2018 · 6 comments

Comments

@tajila
Copy link
Contributor

tajila commented Feb 26, 2018

Andrew - "we need to ensure the unresolved and resolved cases are tested in the JIT for reference type dynamic constants as well as the various primitive typed dynamic constants to make sure the code is working correctly"

@DanHeidinga
Copy link
Member

DanHeidinga commented Feb 27, 2018

@smlambert @llxia Are you monitoring the jtreg tests in OpenJDK jdk repo? If you run across any tests for ConstantDynamic aka Condy (JEP 309), we'd appreciate a heads up to avoid duplicating the testing.

@smlambert
Copy link
Contributor

smlambert commented Feb 27, 2018

We are not monitoring the repo, but we do run them at AdoptOpenJDK, including starting to turn on the JDK10 tests, once all of them are enabled, we will have a better view of that set.

@smlambert
Copy link
Contributor

ok, I see the jdk11 label is now on this... so dismiss my comment about looking for ConstantDynamic tests in the Jdk10 tests

@fjeremic
Copy link
Contributor

A part of this is being taken care of in #2870.

@pshipton
Copy link
Member

Can this be closed, or is there more to do?
@DanHeidinga @smlambert @llxia

@DanHeidinga
Copy link
Member

DanHeidinga commented Sep 21, 2018

I think there are more corner cases to cover:

  • Recursive use of Condy
  • More error cases
  • Condy as a BSM arg to another Condy and/or Indy
  • Tests for jdk.internal.reflect.ConstantPool access to Condy
  • Redefinition of a class with a Condy - confirm the condy isn't reresolved

and possibly other cases I've missed.

This should stay open until we've added more testing or identified relevant tests for these cases in OpenJDK that can be run on OpenJ9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants