Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete atomicCompareAndSwapReturn support on Z, Power, and AArch64 #3759

Open
0xdaryl opened this issue Apr 17, 2019 · 3 comments
Open

Complete atomicCompareAndSwapReturn support on Z, Power, and AArch64 #3759

0xdaryl opened this issue Apr 17, 2019 · 3 comments
Labels
arch:aarch64 arch:power arch:z backlog epic

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 17, 2019

Similar to #2174 on x86, complete Z, P, ARM, AArch64 code generator support for inlining:

atomicCompareAndSwapReturnStatusSymbol
atomicCompareAndSwapReturnValueSymbol

@fjeremic @gita-omr
@0xdaryl 0xdaryl mentioned this issue Apr 17, 2019
Open
@fjeremic fjeremic changed the title Complete atomicCompareAndSwapReturn support on Z,P,ARM Complete atomicCompareAndSwapReturn support on Z, Power, and AArch64 Apr 18, 2019
@fjeremic
Copy link
Contributor

I completed a part of this in #2999. I'll be working on the rest shortly as well.

@gita-omr
Copy link
Contributor

After browsing several referenced links I still can't find a design eg.:

  • semantics of the functions
  • the recognition mechanism
  • test cases
  • summary of issues encountered so far

@fjeremic
Copy link
Contributor

fjeremic commented Apr 23, 2019 •
edited
Loading

I raised the same concern when these symbols were originally introduced in #2958 (comment). It seems we did not code tests against them. In the future as a committer I will veto such symbols being added without proper testing and design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch:aarch64 arch:power arch:z backlog epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fjeremic @0xdaryl @gita-omr