Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "bom" type for maven-target locations #625

Open
laeubi opened this issue Mar 28, 2022 · 3 comments
Open

Support "bom" type for maven-target locations #625

laeubi opened this issue Mar 28, 2022 · 3 comments
Labels
pde-integration M2Eclipse PDE Integration

Comments

@laeubi
Copy link
Member

laeubi commented Mar 28, 2022

Currently one could add a pom type already but this will not work for "bom" poms where only managed dependencies are declared.

@laeubi laeubi added the pde-integration M2Eclipse PDE Integration label Mar 28, 2022
@HannesWell
Copy link
Contributor

I think that could be implemented similar like the MavenPomFeatureModel, but instead of only considering dependencies it could consider the dependencies in the dependencyManagment section.
The question is, should standard dependencies then considered as well?

@laeubi
Copy link
Member Author

laeubi commented May 2, 2023

Actually maven has a scope named import:
https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies

So my preferred solution would be that everything works as before, but we have a new delectable scope of import that then considered the dependencyManagment then user can decide if it is a "pom" or a "bom" (because they are both of type pom ...).

@HannesWell
Copy link
Contributor

So my preferred solution would be that everything works as before, but we have a new delectable scope of import that then considered the dependencyManagment then user can decide if it is a "pom" or a "bom" (because they are both of type pom ...).

Sounds good. One can already select the import-scope, but it is not doing the expected things. I assume I just have to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pde-integration M2Eclipse PDE Integration
Projects
None yet
Development

No branches or pull requests

2 participants