Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE when using external folder as the build directory #1760

Merged
merged 1 commit into from
May 21, 2024

Conversation

testforstephen
Copy link
Contributor

fixes #1759

After resolving the NPE issue, the Maven project importer will convert the external folder to a sub folder of current project (e.g. <currentProjectDir>/path/to/external/builddir) and use that as the build output when an external folder is specified as the build directory in the pom.xml.

@mickaelistria
Copy link
Contributor

Thanks, a null-check is always welcome!

@mickaelistria mickaelistria merged commit 8dac835 into eclipse-m2e:master May 21, 2024
1 of 2 checks passed
@testforstephen testforstephen deleted the jinbo_builddir branch May 21, 2024 08:19
@HannesWell HannesWell added this to the 2.6.1 milestone Jun 3, 2024
@jochenw
Copy link

jochenw commented Nov 26, 2024

For the record: I can reproduce #1759 with M2E version 2.6.2.20240828-1954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to import Maven project if its 'build.project.directory' property points to an external folder
4 participants