"Extract all values..." uses wrong key on identical values

[Bananeweizen]

This is part of the improvements video: https://www.youtube.com/watch?v=bUnx9_jF-ig

Note the identical version numbers before the refactoring:

After the refactoring both version numbers wrongly use the same key "...failsafe...", even on the surefire plugin:

[laeubi]

@Bananeweizen this is a feature of lemminx-maven I'm not sure if it is intentional but you might get better feeedback there.

[mickaelistria]

I think it's fine to see such behavior for "Extract all values..." (as opposed to "Extract property" which would only take the current selection). Some typical cases for this feature are JUnit, Spring, Maven itself which often comes with various dependencies to explicit, all using the same version. This feature is meant to cover such case and to introduce 1 property to rule them all.

[Bananeweizen]

Okay, and thanks @laeubi for the clarification. I was already wondering when I created the issue if I'm in the right project, but I didn't remember lemminx that moment.