Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TBD] Add BuildPackConfiguration object to Image Configuration model #2457

Closed
30 tasks
rohanKanojia opened this issue Nov 21, 2023 · 2 comments
Closed
30 tasks

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Nov 21, 2023

Component

JKube Kit

Task description

Part of #439

As a user, I want to be able to customize the behavior of Buildpacks CLI (pack) execution by providing its supported command-line flags, so that I can properly fine tune the generated container image.

We could introduce a configuration object related to buildpacks inside <build> configuration.

This could look something like this:

<plugin>
        <groupId>org.eclipse.jkube</groupId>
        <artifactId>kubernetes-maven-plugin</artifactId>
        <version>${jkube.version}</version>
        <configuration>
                 <images>
                        <image>
                                <name>foo/bar:latest</name>
                                <build>
                                  <buildpack>

                                    <!-- BuildPack configuration options -->

                                  </buildpack>
                                </build>
                          </image>
                    </images>
         </configuration>
 </plugin>

We can have the following fields in BuildPackConfiguration object:

  • publish (boolean)
  • clearCache (boolean)
  • trustBuilder (boolean)
  • dockerHost (String)
  • cacheImage (String)
  • cache (String)
  • path (String)
  • registry (String)
  • network (String)
  • pullPolicy (String)
  • descriptor (String)
  • defaultProcess (String)
  • lifecycleImage (String)
  • env (Map)
  • envFiles (String list)
  • buildpacks (String list)
  • extensions (String list)
  • volumes (String list)
  • tags (String list)
  • workspace (String)
  • gid (int)
  • previousImage (String)
  • sbomOutputDir (String)
  • reportOutputDir (String)
  • creationTime (String)
  • preBuildPacks (String list)
  • postBuildPacks (String list)
  • builderImage (String)
  • runImage (String)

Acceptance Criteria

  • BuildPackConfiguration object added as a field in BuildConfiguration
@manusa
Copy link
Member

manusa commented Nov 22, 2023

We need to discuss the list of supported options, see if they are overlapping with the ones we might already have.

I'm not sure it's a good idea to completely expose every option.

@manusa manusa changed the title Add BuildPackConfiguration object to Image Configuration model [TBD] Add BuildPackConfiguration object to Image Configuration model Nov 22, 2023
@rohanKanojia
Copy link
Member Author

As discussed we're not going to expose all the options for BuildPackConfiguration in initial phase.

Closing this issue

@manusa manusa closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants