Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @Deprecated fields from BuildConfiguration #189

Closed
4 tasks done
manusa opened this issue May 8, 2020 · 0 comments · Fixed by #250
Closed
4 tasks done

Remove @Deprecated fields from BuildConfiguration #189

manusa opened this issue May 8, 2020 · 0 comments · Fixed by #250
Assignees
@manusa
Milestone
1.0.0

Comments

@manusa
Copy link
Member

manusa commented May 8, 2020 •
edited
Loading

Description

BuildConfiguration contains a deprecated field dockerFileDir that is used when building the image in Docker file mode.

Taking advantage we're moving away from FMP this field should be completely removed. This is a critical field.

Tasks

  • Remove field from model class
  • Update plugin documentation
  • Check quick starts possibly using the field
  • Check e2e tests
@manusa manusa added this to the 1.0.0 milestone May 8, 2020
@manusa manusa self-assigned this Jun 16, 2020
@manusa manusa linked a pull request Jun 19, 2020 that will close this issue
refactor: Remove @Deprecated fields from BuildConfiguration #250
Merged
11 tasks
@manusa manusa closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

refactor: Remove @Deprecated fields from BuildConfiguration manusa/jkube
1 participant
@manusa