Intermittent Class Loading Issues with Java Core Packages #3296
Conversation
|
test this please |
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JavaLanguageServerPlugin.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
|
@rgrunber I have updated the PR. |
|
test this please |
| @@ -174,6 +177,27 @@ public void start(BundleContext bundleContext) throws Exception { | |||
| if (System.getProperty(AssistOptions.PROPERTY_SubstringMatch) == null) { | |||
| System.setProperty(AssistOptions.PROPERTY_SubstringMatch, "false"); | |||
| } | |||
| // https://github.com/redhat-developer/vscode-java/issues/3797 | |||
| Job initializeAfterLoad = new Job("Initialize After Load") { | |||
There was a problem hiding this comment.
Does this actually fix the issue ? I ask because when this job is scheduled, the client has probably not yet connected, nor has the server finished the initialized request. Looking though JavaCore.initializeAfterLoad(..), it seems like the kind of thing that should run after project import ? Does that make sense or is this location correct.
There was a problem hiding this comment.
Yes, it does. I have tried without it and Java LS always rebuilds indexes at cb2bbb7#diff-f23d0258ce24117c110acd6753e8490a09fbdf0bc039d662bdffe279c8c28469R742
We don't want to rebuild indexes every time.
You can try to comment it, and you will get rebuild indexes in the log.
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
Fixes