-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience wrappers for starting the server from the command line #748
Comments
ping? |
@joaotavora If you create a PR we will review it. |
@joaotavora sound like a nice enhancement, but I'm not sure it'll be easy to make a script that fits all sorts of JDK combinations. I absolutely suck at that sort of things so, feel free to provide a PR, as @snjeza said |
See #2005. If there's anything missing or ways to improve it, feel free to open an issue for it. |
@rgrunber thanks! This seems to be "just want the doctor ordered"! I'll open an issue on our side to see if we can integrate it soon. |
In joaotavora/eglot#63, we're adding built-int support for this LSP server. It's mostly working.
Though it's possible to start it from the command line (as seen in here), the number and shape of command line arguments that have to be given makes for a brittle implementation on our side.
To slightly complicate things, the invocation is different on linux/OSX/windows and also different between java versions. Our logic currently tests the current operating system and the java version, and tries to locate the correct jar.
Shouldn't these things be in a wrapper script in the LSP server? I'm thinking two scripts one
.sh
for linux/macosx and one.bat
(shudder) for windows. Do you have any thoughts on this? Would you accept a pull request?The text was updated successfully, but these errors were encountered: