-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
com.kotcrab.remark:remark will be archived #2214
Comments
We should explore alternatives, I don't really want to maintain a whole other library. https://github.com/vsch/flexmark-java might be interesting. Others might fit too. |
MDFromHTML likely doesn't have @NikolasKomonen's fixes. You'd have to check and port them if necessary. |
I tried using flexmark-java in lemminx:
|
My experiments using flexmark in lemminx are rather positive so far, except it doesn't run in binary mode yet. Anyways, this doesn't concern jdt.ls, so I will port my code here. It's annoying it now adds ~4MB of jars, but there's no need to use some reflection hack to configure JSoup anymore. |
As per kotcrab/remark-java#4 , https://github.com/kotcrab/remark-java will be archived.
It's also used by the XML language server to convert HTML to Markdown. Are there any actively maintained alternatives or will we end up just forking it in some other repo ?
CC @testforstephen , @fbricon
Update : Maybe https://github.com/IBM/MDfromHTML ?
Update 2 : remark depends on jsoup, which is vulnerable to GHSA-gp7f-rwcx-9369 . However, in our case, Javadoc don't use
javascript:
do they ?The text was updated successfully, but these errors were encountered: