Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AspectModelFileLoader.load returns wrong headerComment #701

Open
external-Bogdan-Toma opened this issue Jan 23, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@external-Bogdan-Toma
Copy link

How: List of performed steps

What: Actual result vs expected result

  1. Using AspectModelFileLoader.load does not respect rules refering to headerComment
    https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/blob/main/documentation/decisions/0008-copyright-and-license-information.md#more-information
    "All copyright and license information for an aspect model file is given at the beginning of a file in one continuous block ("the comment block") of commented lines (lines that start with the # symbol), before any @Prefix declarations."
    Having
#
# Copyright (c) 2023 Robert Bosch Manufacturing Solutions GmbH, Germany. All rights reserved.
#


# Other comment

=> AspectModelFileLoader.load will return all lines as headerComment

  1. Having header comment without an empty line after it
#
# Copyright (c) 2023 Robert Bosch Manufacturing Solutions GmbH, Germany. All rights reserved.
#
@prefix :       <urn:samm:com.xyz:0.0.1#>.

AspectModelFileLoader.load will return as headerComment

#
# Copyright (c) 2023 Robert Bosch Manufacturing Solutions GmbH, Germany. All rights reserved.

It will cut the last line from headerComment.

Where: (e.g. component, version, url, your system info)
esmf-aspect-meta-model-java:2.9.7

Input (files/screenshots)

Output (files/screenshots)

Additional context (e.g. references)

@external-Bogdan-Toma external-Bogdan-Toma added the bug Something isn't working label Jan 23, 2025
@external-Bogdan-Toma external-Bogdan-Toma changed the title [BUG] [BUG] AspectModelFileLoader.load returns wrong headerComment Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant