Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] All dialogs/popups should have consistent buttons #226

Open
atextor opened this issue Jun 14, 2024 · 2 comments
Open

[BUG] All dialogs/popups should have consistent buttons #226

atextor opened this issue Jun 14, 2024 · 2 comments
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working

Comments

@atextor
Copy link
Contributor

atextor commented Jun 14, 2024

How: List of performed steps

  • Open various popups (details below)

What: Actual result vs expected result
Expected: All popups consistently have an X closing button, possibly also "OK" button to close
Actual: Some popups have an X, some have OK/Cancel, some don't...

Input (files/screenshots)

"Workspace" does have an X button:
image
But "SAMM Elements" doesn't:
image

"Settings" has Cancel / Apply / OK:
image

But "Notifications" does not:
image
(it should have an "OK" button to close)

Neither does the "Help" dialog:
image

(it should also have an "OK" button to close)

And the "Entity Properties Configuration" dialog has Cancel and Save:
image

@atextor atextor added the bug Something isn't working label Jun 14, 2024
@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Jun 21, 2024
@chris-volk
Copy link
Contributor

chris-volk commented Jun 25, 2024

Occured on 5.5.0 linux

@chris-volk
Copy link
Contributor

  • For all dialogs that currently don't have any button (e.g. help, notifications), add one primary button labelled "Close".
  • Investigate why the Close button for SAMM Elements is missing (on my machine it's there, 5.6.0 windows)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants