Tool conflict prevents modifying selected tools

[gtoombs-avidrone]

Description

The bug described here:

#28 Tool conflict in tool chain editor

and here:

Conflict while editing tools

is described as benign, but doesn't particularly seem to be benign. For x8664 MinGW C++ targets, I'm able to modify my Used Tools, but for Cross ARM targets, I'm not. Whenever this warning appears, any changes to the selected tools silently fail.

Steps to Reproduce

1. Open the project properties
2. Click on C/C++ Build
3. Click on Tool Chain Editor
4. Observe that the Current Toolchain is set to Arm Cross GCC
5. Observe that the Current Builder is set to Gnu Make Builder
6. Observe that, in Used Tools, there appear entries for Assembler and Archiver
7. Click on Select Tools...
8. Click on Allow All Changes
9. Remove: GNU Arm Cross Assembler, GNU Arm Cross C Compiler, Gnu Arm Cross C Linker, GNU Arm Cross Archiver, leaving only Cross Arm C++ Compiler, Cross Arm C++ Linker, Cross ARM GNU Create Flash Image, Cross ARM GNU Create Listing, Cross ARM GNU Print Size
10. Click OK
11. Observe that nothing in the Used Tools has changed.

Expected behaviour: Be able to remove unwanted tools.

Actual behaviour: Silent failure when attempting to remove unwanted tools while the conflict message appears.

Versions

• Eclipse Embedded CDT version: 6.5.0.202401111557
• org.eclipse.cdt.core plugin version: 8.4.0.202402110645
• Eclipse version: 2024-03 (4.31.0)
• Java version: OpenJDK 64-Bit Server VM 22
• operating system: Windows
• Toolchain version: xpack-dev-tools\arm-none-eabi-gcc\7.3.1-1.2.2

[ilg-ul]

I remember this very old issue, but I don't have a solution for it, I guess it is a subtle interaction between the toolchain definition and the CDT logic.

If you have a patch that fixes it, we'll consider it.