Pass the Server Address, Server Port, and UserProperties to Session. #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Session#getRequestURI to contain protocol, hostname, and port Update Session#getUserProperties to contain ServerEndpointConfig#getUserProperties Make ServerEndpointConfig#getUserProperties possibly copied not to modify the properties between two modifyHandshakes Signed-off-by: jansupol <[email protected]>
…serProperties is a copy Signed-off-by: jansupol <[email protected]>
Signed-off-by: jansupol <[email protected]>
Signed-off-by: jansupol <[email protected]>
…t proper properties Signed-off-by: jansupol <[email protected]>
Signed-off-by: jansupol <[email protected]>
m0mus
approved these changes
Mar 10, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Session#getRequestURI to contain protocol, hostname, and port
Update Session#getUserProperties to contain ServerEndpointConfig#getUserProperties
Make ServerEndpointConfig#getUserProperties possibly copied not to modify the properties between two modifyHandshakes
Signed-off-by: jansupol [email protected]