Support ClientEndpointConfig#getSSLContext

[jansupol]

Signed-off-by: jansupol [email protected]

[m0mus]

LGTM

[NilsRenaud]

I'm facing an issue with this change, is there any reason you removed these lines ?

(containers/grizzly-client/src/main/java/org/glassfish/tyrus/container/grizzly/client/GrizzlyClientSocket.java#758-761)

if (configuratorObject instanceof SslEngineConfigurator) {
    return new ExtendedSSLEngineConfigurator((SslEngineConfigurator) configuratorObject, uri.getHost());
}

@jansupol

[jansupol]

@NilsRenaud
As you can see the lines were duplicated and now Tyrus 2.1.0 contains just a single copy of that condition.

The change is only in EE10 branch. If you are using the EE10 branch, could your issue be caused by missing EE10 dependencies? Tyrus 1.19 (EE8), 2.0.4 (EE9) still contain the condition duplicated.

[NilsRenaud]

Nop that's not duplicated line, the first line is org.glassfish.tyrus.client.SslEngineConfigurator and the second one is org.glassfish.grizzly.ssl.SSLEngineConfigurator

The second one allowed us to disable TLS hostname verification.

[jansupol]

oops, you are right. That needs to be fixed.

[NilsRenaud]

I've created an issue to track the fix : #804 :)

[jansupol]

@jansupol 2.1.2 containing the fix is public now.

[NilsRenaud]

Thanks a lot @jansupol !