[646] Fixed possible client hang when connecting to server. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using secure connection (wss) while in the conditions of a bad network connection, the client connection thread can hang in JdkClientContainer's connectSynchronously() method, because it never receives neither completed() nor failed() callback. Missing failed() call added for fix. Bug: eclipse-ee4j#646 Signed-off-by: Vladimir Golyakov <[email protected]>
Bug: eclipse-ee4j#646 Signed-off-by: Vladimir Golyakov <[email protected]>
…angTest Bug: eclipse-ee4j#646 Signed-off-by: Vladimir Golyakov <[email protected]>
Bug: eclipse-ee4j#646 Signed-off-by: Vladimir Golyakov <[email protected]>
lprimak
approved these changes
May 12, 2021
|
@arjantijms this one too? |
arjantijms
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #646 and test.
Thanks to @greenmancm for observations.