Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OpenID Connect implementation and related beans are eagerly loaded even when not required. #328

Open
darranl opened this issue Aug 16, 2022 · 2 comments
Assignees

Comments

@darranl
Copy link
Contributor

darranl commented Aug 16, 2022

It would be better to review how much needs to be eagerly loaded and how much can be deferred until deemed necessary for the deployment. Although identified due to the addition of OpenID Connect this should really apply to all beans to ensure resources are not being utilised unnecessarily.

@darranl darranl self-assigned this Aug 16, 2022
@arjantijms
Copy link
Contributor

I agree. I wondered about this too when reviewing the code. Some extensive testing didn't reveal any blocking issues here, but it would be good to look at it.

Patching in the original developer: @jGauravGupta

@darranl
Copy link
Contributor Author

darranl commented Aug 17, 2022

Within WildFly at the time of deployment we scan the annotations used in the deployment and if we detect EE security annotations we activate the Soteria EE security extension.

One simple approach for us could be if the mechanisms were contained in their own extensions - depending on which annotations were encountered when scanning the deployment we could select which extensions could be enabled.

But how do other server's perform their initialisation? Could they also select which Soteria extensions to enable based on the needs of the deployment or is it more common elsehwere to have the whole of Soteria active by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants