Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "JBoss" code from Soteria #326

Open
darranl opened this issue Aug 16, 2022 · 4 comments
Open

Remove "JBoss" code from Soteria #326

darranl opened this issue Aug 16, 2022 · 4 comments
Assignees

Comments

@darranl
Copy link
Contributor

darranl commented Aug 16, 2022

This code is based on the PicketBox implementation which is no longer present in WildFly.

@darranl darranl self-assigned this Aug 16, 2022
@keilw
Copy link
Member

keilw commented Aug 17, 2022

@darranl Why should it have to be removed? I assume it has something to do with the "wildfly" build profile?

@keilw
Copy link
Member

keilw commented Aug 17, 2022

Is there any relationship to #246?

@darranl
Copy link
Contributor Author

darranl commented Aug 17, 2022

@keilw Soteria is now Jakarta EE 10, the first WildFly release to be Jakarta EE 10 will be WildFly 27. The "jboss" code presently contained within Soteria is non functional as the various classes referenced by this integration no longer exist.

Regarding #246 this should now be closed as WildFly 15 is no longer a suitable target for testing. The following issue will update to provision WildFly 27 suitable for testing with Soteria #276

For the "jboss" code to be deleted a replacement is needed for WildFly hence #327 to make it easier to plug in server specific implementations, it looks like the initial classes used by SecurityContextImpl were designed as interfaces to make them pluggable but this was never exposed.

@arjantijms
Copy link
Contributor

Thanks @darranl

Ultimately the integration code present within Soteria should be handled in a better way, preferably by something standardised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants