[2.x] ParamConverterProvider constructors are now protected to allow extensibility #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
param-converters-constructor
branch
from
e5dbbba to
312b401
Compare
|
could you please make those constructors |
Spikhalskiy
force-pushed
the
param-converters-constructor
branch
from
312b401 to
5784b64
Compare
|
@senivam I made them protected and I also added a protected no-op constructor to |
senivam
reviewed
Nov 8, 2024
core-common/src/main/java/org/glassfish/jersey/internal/inject/ParamConverters.java
Outdated
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
param-converters-constructor
branch
from
5784b64 to
6021e7b
Compare
Spikhalskiy
changed the title
jansupol
approved these changes
Nov 12, 2024
Spikhalskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5791 and opens back up constructors that were ?unintentionally? closed in #5349.
This allows users to decorate or extend the functionality of built-in providers without fully copy-pasting the implementations into user projects.