-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last-Modified header is garbled when accessing wadl document on Japanese locale #5698
Merged
jbescos
merged 2 commits into
eclipse-ee4j:2.x
from
vavishal:lastModified_garbled_wadl_document
Jul 16, 2024
Merged
Last-Modified header is garbled when accessing wadl document on Japanese locale #5698
jbescos
merged 2 commits into
eclipse-ee4j:2.x
from
vavishal:lastModified_garbled_wadl_document
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ese locale Signed-off-by: Vaibhav Vishal <[email protected]>
…ese locale Signed-off-by: Vaibhav Vishal <[email protected]>
jbescos
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
senivam
approved these changes
Jul 16, 2024
senivam
pushed a commit
to senivam/jersey
that referenced
this pull request
Jul 25, 2024
…ese locale (eclipse-ee4j#5698) * Last-Modified header is garbled when accessing wadl document on Japanese locale Signed-off-by: Vaibhav Vishal <[email protected]>
1 task
1 task
This was referenced Jul 30, 2024
Closed
1 task
This was referenced Aug 2, 2024
1 task
1 task
This was referenced Sep 7, 2024
1 task
This was referenced Sep 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last-Modified header is garbled when accessing wadl document on Japanese locale
Also calling javax.ws.rs.core.Response.getLastModified() on Japanese locale throws "org.glassfish.jersey.message.internal.HeaderValueException: Unable to parse "Last-Modified" header value:"
So, Locale.US was added as default locale in the fix
The testcase also exists at jersey/tests/e2e-server/src/test/java/org/glassfish/jersey/tests/e2e/server/wadl/WadlResourceTest.java
Signed-off-by: Vaibhav Vishal [email protected]