Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsp plugin updates #940

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

markt-asf
Copy link
Contributor

Fixes Issue
#937

Related Issue(s)
Previous PR #938

Describe the change
Modify the TCK so jsp:plugin syntax in JSP pages is still validated but the action is a NO-OP in terms out HTML output.

Additional context
jakartaee/pages#226

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow

@scottmarlow scottmarlow merged commit e657dfd into jakartaee:master Apr 21, 2022
@alwin-joseph
Copy link
Contributor

alwin-joseph commented Apr 25, 2022

There are 5 test failures for Pages now , looks like related to this change.

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/107/
GF: https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-SNAPSHOT-nightly.zip

@markt-asf @arjantijms Can you please suggest.

@markt-asf markt-asf deleted the jsp-plugin-updates branch April 25, 2022 15:59
@markt-asf
Copy link
Contributor Author

Glassfish's JSP engine will need updating to NO-OP <jsp:plugin> actions.

@arjantijms
Copy link
Contributor

Glassfish's JSP engine will need updating to NO-OP jsp:plugin actions.

Indeed. Easiest would be to make the updated TCK available at the usual location, and then I can easily do a PR for GF to pass that updated TCK.

@alwin-joseph
Copy link
Contributor

Glassfish's JSP engine will need updating to NO-OP jsp:plugin actions.

Indeed. Easiest would be to make the updated TCK available at the usual location, and then I can easily do a PR for GF to pass that updated TCK.

The latest TCK is now available at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-pages-tck-3.1.0.zip , built today (https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-pages-tck-3.1.0-tckinfo.txt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants