Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataplanePublicApiControler completable future failure messages are returned as contatenated string #4670

Open
rafaelmag110 opened this issue Dec 12, 2024 · 1 comment · May be fixed by #4678
Labels
enhancement New feature or request

Comments

@rafaelmag110
Copy link
Contributor

Bug Report

Describe the Bug

In the DataplanePublicApiV2Controler, if the CompletableFuture handled by the processRequest method has a result with multiple failure messages, these messages will all be concatenated into a single string, even though the TransferErrorResponse handles a list of errors.

Expected Behavior

Since the end result to the client is a list of errors, it would be expected that response includes an actual list of errors and not a concatenated string of errors.

Observed Behavior

image

Here a Details list should be a single error, but all are concatenated.

@github-actions github-actions bot added the triage all new issues awaiting classification label Dec 12, 2024
@rafaelmag110
Copy link
Contributor Author

I think this is a good first issue. Can label it anymore since I've lost my contributor status :(

@rafaelmag110 rafaelmag110 changed the title DataplanePublicApiControler completable future failure is processed as contatenated string DataplanePublicApiControler completable future failure messages are returned as contatenated string Dec 12, 2024
@kkotowiczz kkotowiczz linked a pull request Dec 16, 2024 that will close this issue
@ndr-brt ndr-brt added enhancement New feature or request and removed triage all new issues awaiting classification labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants