Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsp: fixes related to DSP conformance #4543

Closed
jimmarino opened this issue Oct 13, 2024 · 0 comments · Fixed by #4544
Closed

dsp: fixes related to DSP conformance #4543

jimmarino opened this issue Oct 13, 2024 · 0 comments · Fixed by #4544
Assignees
@jimmarino
Labels
bug_report Suspected bugs, awaiting triage dataspace-protocol related to the dataspace protocol triage all new issues awaiting classification

Comments

@jimmarino
Copy link
Contributor

Bug Report

The following bugs related to DSP flows need to be fixed:

  • ConsumerContractNegotiationManagerImpl.processAccepting did not pass the current Policy as part of the RemoteMessage when dispatching, causing an NPE during policy evaluation.
  • JsonObjectToPolicyTransformer did not deserialize assignee and assigner if the policy type is an agreement, which is required by DSP
  • DspHttpRemoteMessageDispatcherImpl did not report the HTTP error code
  • DspRequestHandlerImpl reported the incorrect validation context
  • ContractNegotiation did not allow for a valid state transition (OFFERED)
  • ContractNegotistion should not allow transitions from FINALIZED to TERMINATED
@jimmarino jimmarino added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification dataspace-protocol related to the dataspace protocol and removed triage all new issues awaiting classification labels Oct 13, 2024
@jimmarino jimmarino self-assigned this Oct 13, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Oct 13, 2024
@jimmarino jimmarino mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmarino jimmarino

Labels
bug_report Suspected bugs, awaiting triage dataspace-protocol related to the dataspace protocol triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fixes related to DSP conformance jimmarino/DataSpaceConnector
1 participant
@jimmarino