Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DataAddressValidator works also for other data address types #3557

Closed
ndr-brt opened this issue Oct 20, 2023 · 0 comments · Fixed by #3570
Closed

make DataAddressValidator works also for other data address types #3557

ndr-brt opened this issue Oct 20, 2023 · 0 comments · Fixed by #3570
Assignees
Labels
enhancement New feature or request

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Oct 20, 2023

Feature Request

Currently the DataAddressValidator only works for HttpData, but if another kind of address is registered as Kafka or other, the asset will be created also if the address is not correct, this would bring hard-to-debug errors on the transfer side, because the data-plane would not be able to start the transfer properly.

Which Areas Would Be Affected?

management api

Why Is the Feature Desired?

user experience

Solution Proposal

  • have the DataAddressValidator extensible
  • provide an extension that registers a DataAddressValidator for every known DataAddress
  • make the DataAddressValidator fail if there's no validator for a specific data address type
  • use the DataAddressValidator in the dataplane as well (to remove duplication)
@ndr-brt ndr-brt added feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Oct 20, 2023
@ndr-brt ndr-brt added enhancement New feature or request and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Oct 25, 2023
@ndr-brt ndr-brt self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant