sql: lease flaw

[ndr-brt]

Bug Report

Describe the Bug

We're not handling the lease correctly when we update an entity, e.g.

Connector/extensions/control-plane/store/sql/transfer-process-store-sql/src/main/java/org/eclipse/edc/connector/store/sql/transferprocess/store/SqlTransferProcessStore.java

Lines 146 to 147 in d2f8e13

	leaseContext.by(leaseHolderName).withConnection(conn).breakLease(entity.getId());
	update(conn, entity, existing.getDataRequest().getId());

or

Connector/extensions/control-plane/store/sql/contract-negotiation-store-sql/src/main/java/org/eclipse/edc/connector/store/sql/contractnegotiation/store/SqlContractNegotiationStore.java

Lines 110 to 111 in d2f8e13

	leaseContext.withConnection(connection).breakLease(id);
	update(connection, id, negotiation);

(it's like this pretty much on every sql store implementation).

Expected Behavior

The correct behavior is shown in the delete implementation:

Connector/extensions/control-plane/store/sql/contract-negotiation-store-sql/src/main/java/org/eclipse/edc/connector/store/sql/contractnegotiation/store/SqlContractNegotiationStore.java

Lines 132 to 139 in d2f8e13

	// attempt to acquire lease - should fail if someone else holds the lease
	leaseContext.withConnection(connection).acquireLease(negotiationId);
	var stmt = statements.getDeleteTemplate();
	queryExecutor.execute(connection, stmt, negotiationId);
	//necessary to delete the row in edc_lease
	leaseContext.withConnection(connection).breakLease(negotiationId);

we should acquire the lease BEFORE executing the update statement, and the breakLease should happen after it.

Possible Implementation

To have this working in the correct way, the acquireLease method should change a bit:

Connector/extensions/common/sql/sql-lease/src/main/java/org/eclipse/edc/sql/lease/SqlLeaseContext.java

Lines 81 to 83 in d2f8e13

	if (lease != null && !lease.isExpired(clock)) {
	throw new IllegalStateException("Entity is currently leased!");
	}

it should not fail when the acquireLease is ran by the lease holder, in this case likely it should "renew" the lease.

In fact this flaw could be somehow related to #3514