Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy-monitor: data flow should be stopped on transfer completion #3453

Closed
Tracked by #3422
ndr-brt opened this issue Sep 14, 2023 · 0 comments · Fixed by #3481
Closed
Tracked by #3422

policy-monitor: data flow should be stopped on transfer completion #3453

ndr-brt opened this issue Sep 14, 2023 · 0 comments · Fixed by #3481
Assignees
Labels
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Sep 14, 2023

Feature Request

When the TransferProcess gets completed by the policy monitor, it should terminate the data flow accordingly.

This should be done either on the DataFlowControllerRegistry that need to find the correct DataFlowController and terminate the flow, or in the "deprovisioning" phase.

The only implementation we need to put in place would be for the ProviderPushTransferDataFlowController, where the terminate call should be done either:

  • on the previous choosed dataplane
  • on every dataplane that can handle that dataflow.
    likely the second one is the correct one, because the dataplane that started the dataflow could have been stopped and replaced with another one,

The consumer-pull flow does not need a terminate method because the token expiration will already do the job.

Which Areas Would Be Affected?

e.g., DPF, CI, build, transfer, etc.

Why Is the Feature Desired?

Are there any requirements?

Solution Proposal

If possible, provide a (brief!) solution proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant